<html>
<head><meta charset="utf-8"><title>Approval for new lint? · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html">Approval for new lint?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="207373622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207373622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207373622">(Aug 19 2020 at 06:13)</a>:</h4>
<p>For <a href="https://github.com/rust-lang/rust/issues/75239">https://github.com/rust-lang/rust/issues/75239</a>, a new lint feels appropriate. I thought we could just make a PR and maybe ask for t-compiler FCP in there, but now I heard from <span class="user-mention" data-user-id="124288">@oli</span> they think RFC or at least MCP is necessary for a lint. What is the process here?</p>



<a name="207373669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207373669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207373669">(Aug 19 2020 at 06:14)</a>:</h4>
<p>To me, a new lint doesn't feel "major" at all, so I was quite surprised that paperwork (beyond FCP) would be required^^</p>



<a name="207387527"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207387527" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lzutao <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207387527">(Aug 19 2020 at 09:41)</a>:</h4>
<p>I want that lint too. But I agree that new lint should be accepted by compiler team.<br>
Since the lint has to maintain forward compatible with new Rust releases.</p>



<a name="207390355"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207390355" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207390355">(Aug 19 2020 at 10:16)</a>:</h4>
<p>My understanding historically has been that compiler team approval is not necessary and Lang team approval is.</p>



<a name="207390383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207390383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207390383">(Aug 19 2020 at 10:16)</a>:</h4>
<p>I guess we can discuss this Thursday</p>



<a name="207393261"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207393261" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207393261">(Aug 19 2020 at 10:52)</a>:</h4>
<p>oh, wrong team then. fair.<br>
my question was more about FCP vs something more heavy.</p>



<a name="207393280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207393280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207393280">(Aug 19 2020 at 10:53)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F/near/207390383">said</a>:</p>
<blockquote>
<p>I guess we can discuss this Thursday</p>
</blockquote>
<p>okay, I'll nominate for lang team discussion</p>



<a name="207401280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207401280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207401280">(Aug 19 2020 at 12:36)</a>:</h4>
<p>heh I meant compiler team discussion to confirm compiler team does not want to approve, but sure</p>



<a name="207401394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207401394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207401394">(Aug 19 2020 at 12:38)</a>:</h4>
<p>I think FCP is more than sufficient personally, I'd be fine with MCP-style "no objections" too</p>



<a name="207490870"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207490870" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207490870">(Aug 20 2020 at 05:49)</a>:</h4>
<p><span class="user-mention" data-user-id="120791">@RalfJ</span> I personally think that an FCP is <em>completely</em> sufficient here.</p>



<a name="207490871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207490871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207490871">(Aug 20 2020 at 05:49)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/75239#issuecomment-677195651">https://github.com/rust-lang/rust/issues/75239#issuecomment-677195651</a></p>



<a name="207509453"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207509453" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207509453">(Aug 20 2020 at 10:46)</a>:</h4>
<p>let me add this to the list of "policy things to clarify"</p>



<a name="207509464"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Approval%20for%20new%20lint%3F/near/207509464" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Approval.20for.20new.20lint.3F.html#207509464">(Aug 20 2020 at 10:46)</a>:</h4>
<p>I agree that nominating the PR and asking for FCP on the PR suffices</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>